Warning messages on system_certmanager.php page after installation haproxy pkg

ardu

Hi,
on a pfSense 2.3-RELEASE (amd64) I've several certificates used for OpenVPN.

I had no problems to browse the certificate list (page /system_certmanager.php) until I've installed the haproxy package.

Now in the certificates list I see the following warning in the header and in the "Actions" column on every certificate.

Warning: Invalid argument supplied for foreach() in /usr/local/pkg/haproxy/haproxy.inc on line 2140

Call Stack:
0.0001 228000 1. {main}() /usr/local/www/system_certmanager.php:0
0.0326 1567216 2. pkg_call_plugins() /usr/local/www/system_certmanager.php:988
0.0429 1776272 3. call_user_func:{/etc/inc/pfsense-utils.inc:3080}() /etc/inc/pfsense-utils.inc:3080
0.0429 1776336 4. haproxy_plugin_certificates() /etc/inc/pfsense-utils.inc:3080

A crash report is also generated and sent to developers.

Is there an updated release that will fix this issue?

Thanx.

PiBa

Is there an updated release that will fix this issue?
No not yet, issues must first be found before they are fixed ;)

Probably very little configuration made sofar in haproxy (i suspect not a single backend configured)?

Anyway i should check for empty arrays before using them. Ill try and send a fix tonight.

ardu

Is there an updated release that will fix this issue?
No not yet, issues must first be found before they are fixed ;)

Sorry, I didnt want to be rude ;-)
I didnt know if the issue was already reported (search done but none found).

Probably very little configuration made sofar in haproxy (i suspect not a single backend configured)?

I confirm that: The warning disappeared after I configured at least a backend in haproxy

Thank you!

PiBa

No apology needed, you were not rude. Its just that i think you recently installed haproxy, which would have been the latest version at that time, i found the question somewhat funny to ask if a update is available if you've installed the latest version available just hours earlier.

Anyway ill fix that warning, empty not yet existing array's should not be looped over. I do try to test new features when added in a few different configurations, but a empty config is not always one of them.

If you do find other issues please don't hesitate to report them :)

PiBa

Anyway, a fix has been submitted on github https://github.com/pfsense/FreeBSD-ports/pull/123 , now it needs to get pulled which might take a few days, and a few minutes after that pfSense 2.3 package manager should be able to show that a newer version is available for installation.

foetus

I was just going to create a topic for this :).
Thank you for the quick response.