Hi,
Just wanted to report back that, your advice was correct and when I checked my actual config, i had done all that. It was in fact fine.
My problem was situational… in that my connection is PPPoE so when i send FW1 for a reboot during testing, i have to wait until that PPPoE is established on FW2, the CARP VIP's are transferred to FW2 and eventually the VPN connection will come back up. The issue was FW1 rebooted so fast that it causes a flip flop effect whereby it takes the CARP Master roles back...but the PPPoE WAN connection is still up on FW2 until i reboot it.
I have now tested this all works with a full shutdown of one node (and someone on site to power it back up :) ) and visa versa.
Interestingly the VPN all stay up despite the FW2 now having the backup CARP role for the VPN VIP, This may be due to the fact I do connect with "other" -> "ovpn.domain.com" in my client exports and that resolves anywhere with applicable DNS lookup to the CARP VPN VIP (an alias on the WAN). Seems this is nice and versatile.
If you have any suggestion for how to handle an automatic failback (although doing it manually is ok) ....whereby the PPPoE gets dropped from FW2 back to FW1 if it comes back up i'd love to hear about that.
Also I'll raise a seperate topic for this if I can't get it to work, but is there an easy way of assigning a static ip to an openvpn client, obviously not in the main network range but just making sure it gets the same ip everytime it connects in without creating a ton of different servers. I've read a bit about doing this but wondered if there was a nice way through the web gui... most other methods are detailed file edits in the underlying FreeBSD system?
On 2.2.4 on both nodes now.
Thanks.