pfSense 2.7 with an old 2.4.5 config failing to upgrade

[stephenw10]

@davin-landry said in pfSense 2.7 with an old 2.4.5 config failing to upgrade:

upgrade_config.inc:4163

That code updates custom gateway monitoring settings to be valid in newer instances.
https://github.com/pfsense/pfsense/blob/master/src/etc/inc/upgrade_config.inc#L4161

Do you have custom gateway values in your config?

Steve

[davin.landry]

@stephenw10

Yes I do, we have 4 entries in 'Gateways' and 2 rely on the IPSec connection.

Also, sorry for the delay in responding.

[stephenw10]

Ah so gateways at the remote side of a VTI tunnel?

That should still be valid. Do you have custom values in those? Latency, ping frequency etc?

[davin.landry]

Yeah, they are for AWS. But no, no custom values, just have monitoring turned off.

[stephenw10]

Can we see the gateways section from the config you are importing? You can redact any public IP there if you wish.

[davin.landry]

config-router.xml

[stephenw10]

That appears to be only the ipsec config. What matters here is the gateway section like:

	<gateways>
		<gateway_item>
			<interface>opt9</interface>
			<gateway>172.27.116.1</gateway>
			<name>WG0GW</name>
			<weight>1</weight>
			<ipprotocol>inet</ipprotocol>
			<descr></descr>
			<monitor_disable></monitor_disable>
			<gw_down_kill_states></gw_down_kill_states>
		</gateway_item>
		<gateway_item>
			<interface>opt14</interface>
			<gateway>dynamic</gateway>
			<name>GIF0_TUNNELV4</name>
			<weight>1</weight>
			<ipprotocol>inet</ipprotocol>
			<descr><![CDATA[Interface GIF0_TUNNELV4 Gateway]]></descr>
		</gateway_item>
		<gateway_item>
			<interface>opt17</interface>
			<gateway>dynamic</gateway>
			<name>WWAN0_PPP</name>
			<weight>1</weight>
			<ipprotocol>inet</ipprotocol>
			<interval>5000</interval>
			<time_period>100000</time_period>
			<alert_interval>20000</alert_interval>
			<descr><![CDATA[Interface WWAN0_PPP Gateway]]></descr>
			<monitor>1.1.1.1</monitor>
			<loss_interval>19995</loss_interval>
		</gateway_item>
		<gateway_item>
			<interface>opt25</interface>
			<gateway>10.0.2.1</gateway>
			<name>WG_GW0</name>
			<weight></weight>
			<ipprotocol>inet</ipprotocol>
			<descr><![CDATA[Wireguard gateway]]></descr>
			<gw_down_kill_states></gw_down_kill_states>
		</gateway_item>
		<defaultgw4>WAN_DHCP</defaultgw4>
		<defaultgw6></defaultgw6>
	</gateways>

[davin.landry]

Sorry. Here you go.

config-router.xml

[stephenw10]

Great. Nothing jumps out at me there, I've raised it with our devs.

[stephenw10]

Hmm, OK are you able to retest that?

If so try removing the <interval/> lines from the config before importing it. If that prevents the error we should be able to add something to allow it.

[davin.landry]

Yes I can retry, I'll let you know something after the holiday.

[davin.landry]

Test was successful most of the settings are now in the new system. A few things aren't working, like the openVPN service and DHCP service won't start but I think it might be because it doesn't have any real connections.
I'm also getting the following error now.

PHP Errors:
[28-Nov-2023 03:29:20 America/Chicago] PHP Fatal error: Uncaught TypeError: Cannot access offset of type string on string in /etc/inc/upgrade_config.inc:4290
Stack trace:
#0 /etc/inc/config.lib.inc(513): upgrade_136_to_137()
#1 /etc/rc.bootup(135): convert_config()
#2 {main}
thrown in /etc/inc/upgrade_config.inc on line 4290

[stephenw10]

Still into 2.7.0 not 2.7.1?
https://github.com/pfsense/pfsense/blob/RELENG_2_7_0/src/etc/inc/upgrade_config.inc#L4290

if (!is_array($dhcpd['numberoptions']['item'])) {

Do you have custom numbered options in your dhcp server config?

Steve

[davin.landry]

Yes I have 10 total different networks(vlans) with different scopes and 7 of those use the DHCP server.

[stephenw10]

Right but do any of them have numbered options set like:

[davin.landry]

Yeah, "66" on my phone VLAN.

Oh and yeah I must have downloaded this before the update to 2.7.1, It's been on the workbench a little while. I'll update it.

[stephenw10]

Ok, I don't expect 2.7.1 to be any different but the line numbers in the php error might have changed.