SpamD Package Needs Testers
-
The missing items never existed to begin with. This thread is concerning bugs for existing features only.
Please take your feature requests to the Bounty thread and they will be dealt with separately very soon.
Now with that said, what are the bugs with the existing features now?
From the bounty starter post:
@lambert:I've not previously managed a spamd installation so my requirements will be met by getting the package working and committed to the project with, at least the functionality it had back when sullrich initially built it plus the fixes for issues rcarr noted in his post. I don't know enough about spamd to have further requirements at this time. I'm trying to avoid having to learn it in too much detail too… :-) Too many projects running right now.
http://forum.pfsense.org/index.php/topic,5660.msg33728.html#msg33728
If someone can get it working that far, I can find out what I want changed, if anything, beyond that and offer another bounty.
I believe that at least the following still applies, although he showed the issue differently with an external sources defined whitelist which still shows the same problem.
all:
:whitelist:blacklist:uatraps:nixspam:mywhitelist:should be according to exactly what rcarr had written:
all:
:whitelist:blacklist:uatraps:mywhitelist:nixspam:mywhitelist:The all entry seems to be not generating correctly. This is what is generated:
all:
:whitelist:blacklist:nixspam:uatraps:test:This is what should be generated, assuming you want "blacklist" to override "whitelist" entries:
all:
:nixspam:whitelist:uatraps:whitelist:test:whitelist:blacklistIf you want "whitelist" to override the "blacklist" entries:
all:
:nixspam:whitelist:uatraps:whitelist:test:whitelist:blacklist:whitelistThe fix for the below is to delete line 66 of spamd.inc. If you don't want to, don't. I've paid my part of the bounty.
The SpamD External Sources tab adds entries similar to :
test:
:black:
:msg="you are rejected":
:method=http:
:http:
:file=www.openbsd.org/spamd/traplist.gz:The documentation does not show the :http: entry.
Thanks, I'll get these taken care. It is not that I do not wish to fix these things, I am just trying to keep this thread focused to get it knocked out quickly since I am running out of time before I have to travel for a week. Just trying to get everyone up and running before a long delay.
-
In regards to the ordering issue, I believe you will want to create the entries in the order you want them to apply. This might not be optimal but it does work. Let's discuss improvements to this in the Bounty thread.
-
I'm unsure if this has been reported (I have a feeling it has).
The buttons on the SpamD Database page (the ones for deleting, whitelisting, blacklisting etc.) at the end of the row do not appear to work. I have a SpamTrap address I want to now remove and I'm unable to. I assume manually editing the config files will allow me to do this in the meantime?
This is hte code for the delete button that is showing up in Firefox:
===
javascript:toggle_on("d24", "/themes/nervecenter/images/icons/icon_x_p.gif");getURL("spamd_db.php?buttonid=d24&srcip=The actual code in the source though is (Note that I changed the @ in the javascript below to AT so that it wouldn't show up as a link in the forum and I get MORE spam!)
===
javascript:toggle_on("d24", "/themes/nervecenter/images/icons/icon_x_p.gif");getURL("spamd_db.php?buttonid=d24&srcip=''''catchallATblueivy.co.uk''''&action=delete", outputrule);'It's got something to do with the quotes around \catchallATblueivy.co.uk.
-
===
javascript:toggle_on("d24", "/themes/nervecenter/images/icons/icon_x_p.gif");getURL("spamd_db.php?buttonid=d24&srcip=''''catchallATblueivy.co.uk''''&action=delete", outputrule);'It's got something to do with the quotes around \catchallATblueivy.co.uk.
Looks like maybe just a quote mismatch, you have double quotes in the front of the address and single quotes after the address. Hopefully a simple fix.
-
I am currently traveling without access to fix these issues. If you can, please hold off on further bug reports until I return so that I do not feel overwhelmed. Thanks!
-
I think that there may be an error in parsing "bad" e-mail addresses when displaying the SpamD database:
I'm seeing the following when "sorting by Attempts":
| Type | IP | From | To | Attempts ↑ |
| GREY | 77.205.81.230 | | ty{n2000@HECOUNCIL.ORG> | 1209078047 |
| GREY | 83.9.63.26 | <martac-ti|< td=""></martac-ti|<> | {pyr@AOLLC.COM> | 1209076738 |Knobee
-
I think that there may be an error in parsing "bad" e-mail addresses when displaying the SpamD database:
I'm seeing the following when "sorting by Attempts":
| Type | IP | From | To | Attempts ↑ |
| GREY | 77.205.81.230 | | ty{n2000@HECOUNCIL.ORG> | 1209078047 |
| GREY | 83.9.63.26 | <martac-ti|< td=""></martac-ti|<> | {pyr@AOLLC.COM> | 1209076738 |Knobee
It's a known issue when someone puts a | in the email address.
-
@submicron:
===
javascript:toggle_on("d24", "/themes/nervecenter/images/icons/icon_x_p.gif");getURL("spamd_db.php?buttonid=d24&srcip=''''catchallATblueivy.co.uk''''&action=delete", outputrule);'It's got something to do with the quotes around \catchallATblueivy.co.uk.
Looks like maybe just a quote mismatch, you have double quotes in the front of the address and single quotes after the address. Hopefully a simple fix.
This looks like a parsing bug of some kind, notice there is an email address for the ip address. Can you reproduce this?
-
Here are the issues I've come across so far with our testing:
-
Spamtrap email addresses don't get saved or applied. Entering in an address doesn't add it to the database, and eventually the field is listed again as empty. Re-Adding the entry similarly doesn't work.
-
No RRD Graph reporting. This was part of the original bounty and I'm quite sure it was in the original spamd package.
-
As previously reported, entries in the "queue" cannot be whitelisted, blacklisted or deleted. The icons just wiggle instead of doing anything.
-
-
I concur with those issues. I am seeing the same on one of my client's firewall. I just didn't have time to put it down in words. I personally find the third one most annoying.
Add to this the parsing error that Knobee & blueivy reported earlier. I too am seeing that in some entries.
Francois
-
I'm still trying to chase down why this happened and what the details are, but as soon as I removed a blacklist from the spamd configuration, my shaper rules blew up:
Apr 28 16:54:07 spamlogd[81627]: exiting
Apr 28 16:54:07 spamlogd[81627]: exiting
Apr 28 16:54:09 spamd[77903]: listening for incoming connections.
Apr 28 16:54:09 spamd[77903]: listening for incoming connections.
Apr 28 16:54:12 check_reload_status: reloading filter
Apr 28 16:54:16 php: : New alert found: There were error(s) loading the rules: /tmp/rules.debug:41: syntax error /tmp/rules.debug:46: queue qlanRoot has no parent /tmp/rules.debug:46: errors in queue definition /tmp/rules.debug:48: queue qlandef has no parent /tmp/rules.debug:48: errors in queue definition /tmp/rules.debug:50: queue qlanacks has no parent /tmp/rules.debug:50: errors in queue definition /tmp/rules.debug:52: queue qPenaltyDown has no parent /tmp/rules.debug:52: errors in queue definition /tmp/rules.de
Apr 28 16:54:16 php: : There were error(s) loading the rules: /tmp/rules.debug:41: syntax error /tmp/rules.debug:46: queue qlanRoot has no parent /tmp/rules.debug:46: errors in queue definition /tmp/rules.debug:48: queue qlandef has no parent /tmp/rules.debug:48: errors in queue definition /tmp/rules.debug:50: queue qlanacks has no parent /tmp/rules.debug:50: errors in queue definition /tmp/rules.debug:52: queue qPenaltyDown has no parent /tmp/rules.debug:52: errors in queue definition /tmp/rules.debug:54: queue qP2
Apr 28 16:55:35 spamlogd[77901]: exiting
Apr 28 16:55:35 spamlogd[77901]: exiting
Apr 28 16:55:38 spamd[78329]: listening for incoming connections.
Apr 28 16:55:38 spamd[78329]: listening for incoming connections.
Apr 28 16:55:41 check_reload_status: reloading filter
Apr 28 16:55:46 php: : New alert found: There were error(s) loading the rules: /tmp/rules.debug:41: syntax error /tmp/rules.debug:46: queue qlanRoot has no parent /tmp/rules.debug:46: errors in queue definition /tmp/rules.debug:48: queue qlandef has no parent /tmp/rules.debug:48: errors in queue definition /tmp/rules.debug:50: queue qlanacks has no parent /tmp/rules.debug:50: errors in queue definition /tmp/rules.debug:52: queue qPenaltyDown has no parent /tmp/rules.debug:52: errors in queue definition /tmp/rules.de
Apr 28 16:55:46 php: : There were error(s) loading the rules: /tmp/rules.debug:41: syntax error /tmp/rules.debug:46: queue qlanRoot has no parent /tmp/rules.debug:46: errors in queue definition /tmp/rules.debug:48: queue qlandef has no parent /tmp/rules.debug:48: errors in queue definition /tmp/rules.debug:50: queue qlanacks has no parent /tmp/rules.debug:50: errors in queue definition /tmp/rules.debug:52: queue qPenaltyDown has no parent /tmp/rules.debug:52: errors in queue definition /tmp/rules.debug:54: queue qP2
Apr 28 16:56:06 check_reload_status: reloading filter
Apr 28 16:56:16 php: : New alert found: There were error(s) loading the rules: /tmp/rules.debug:41: syntax error /tmp/rules.debug:46: queue qlanRoot has no parent /tmp/rules.debug:46: errors in queue definition /tmp/rules.debug:48: queue qlandef has no parent /tmp/rules.debug:48: errors in queue definition /tmp/rules.debug:50: queue qlanacks has no parent /tmp/rules.debug:50: errors in queue definition /tmp/rules.debug:52: queue qPenaltyDown has no parent /tmp/rules.debug:52: errors in queue definition /tmp/rules.de
Apr 28 16:56:16 php: : There were error(s) loading the rules: /tmp/rules.debug:41: syntax error /tmp/rules.debug:46: queue qlanRoot has no parent /tmp/rules.debug:46: errors in queue definition /tmp/rules.debug:48: queue qlandef has no parent /tmp/rules.debug:48: errors in queue definition /tmp/rules.debug:50: queue qlanacks has no parent /tmp/rules.debug:50: errors in queue definition /tmp/rules.debug:52: queue qPenaltyDown has no parent /tmp/rules.debug:52: errors in queue definition /tmp/rules.debug:54: queue qP2Anyone seen anything like this?
-
Yep, its definitely related to spamd, I had to kill the install of spamd and now the shaper rules are not broken anymore.
-
I don't see any way that it could be linked to SpamD. I'll have to speak with eri
-
submicron, please send a broken rules.debug to my email (gmail). Thanks
-
I'm still trying to reliably re-create it, if I can, I'll send you the rules.
-
Just fixed all the button operations, delete, spamtrap, etc. Please test!!
-
I just re-installed the package and the jiggly buttons that do nothing still seem to be there.
-
They are still there, but they do work now… Or at least the delete function button worked for me?
-
Apparently they work, but only if you reload the page manually. My personal feeling is that pressing the buttons should cause the page to reload itself, otherwise you'll have lots of people frustratedly thinking that the buttons don't work.
Also, on that same page, the database totals apparently don't work. I have several items listed as "Whitelisted" but the totals show 0 items whitelisted.
-
@submicron:
Apparently they work, but only if you reload the page manually. My personal feeling is that pressing the buttons should cause the page to reload itself, otherwise you'll have lots of people frustratedly thinking that the buttons don't work.
Also, on that same page, the database totals apparently don't work. I have several items listed as "Whitelisted" but the totals show 0 items whitelisted.
There is a little blurb about that on the page at the bottom. The idea is being able to rapdily delete, deny or whitelist a number of domains without having to wait on page reloads… So I dunno, I personally like the ajax option but maybe we just need to hide the table row after an operation occurs.