pfBlockerNG_devel commit reverse

jrey · Oct 7, 2024, 2:40 PM

okay, I'm not going to be able to troubleshoot that I don't use MaxMind for GeoIP data

but there were a lot of changes under the hood with _18 related to how configuration items are handled. There are still a few issues with ASN names where for example strings contains International characters (accented) in the fields that will cause the config save to fail and auto restore said config.

So what I'm suggesting is that if anything in TopSpammers list you are trying to remove has international characters that "might" be a problem based on the issue we see on the ASN side where those strings cause similar issues.
Why I asked for the screen capture of what you are specifically trying to remove, is because I have no idea what is on that screen. I'd be looking however for international (accented) characters just to see if that "could be" the issue here.

Specifically for MaxMind in this case suggest we tag @BBcan177 for more insight.

incith · Oct 7, 2024, 2:46 PM

@jrey
🔒 Log in to view 🔒 Log in to view

Maybe this? Not the one I'm trying to remove (it's already unchecked that is), but maybe it's parsing through it.

jrey · Oct 7, 2024, 2:59 PM

@incith

that would are my guess, but sorry no way for me to troubleshoot this case specifically- it just "looks" like a similar issue to me.

if you want to see a similar error (where the config gets restored) on the ASN side
create or go to a list you already have with ASN data items (assuming you are using ASNs somewhere and have ipinfo.io up and running)

simply try to add (any ASN that contains international characters in the name) and save the list. the data won't be saved and it will "restore" the config.

the new ipinfo data ASN names contain these, the old bgpview ASN data did not.

here are a couple samples (with the new ASN data) that will cause it to fail.. (of course there are many more)

AS29571
AS273867

BBcan177 · Oct 7, 2024, 8:47 PM

Ok there is a bug and it will be fixed in the next upcoming version.

https://github.com/pfsense/FreeBSD-ports/commit/3586bb086db9a1ff7dcddc3e2e30605ecac99796

This can be applied by the System Patches package using the commit ID and setting "Path Strip Count" to 4.

Or you can edit /usr/local/www/pfblockerng.php and change the single quotes to a double quote as per the commit above.

Once that has been patched, you can run this command to rebuild the GeoIP pages:

php -f /usr/local/www/pfblockerng/pfblockerng.php dc

incith · Oct 7, 2024, 9:03 PM

@BBcan177 Works great, thank you!

TommyMoo · Oct 18, 2024, 10:02 PM

Updated today pfblocker devel to version 3.2.0_19, all went well, no problem. Thank you very much, my impression is, that it gained some speed compared to previous version & Thanks for bugfixes

BBcan177 · Oct 19, 2024, 5:41 PM

@TommyMoo

Thanks for reporting.

More info here:

https://www.reddit.com/r/pfBlockerNG/s/4Yrr4ffq3I

tman222 · Oct 19, 2024, 5:41 PM

@BBcan177 said in pfBlockerNG_devel commit reverse:

@TommyMoo

Thanks for reporting.

More info here:

https://www.reddit.com/r/pfBlockerNG/s/4Yrr4ffq3I

Hi @BBcan177 - thanks for this new version; the install went smoothly. I have a quick question about the release: I see that in the release notes that setting the ASN Cache setting is no longer required. Does this mean that under IP -> ASN Configuration -> ASN Reporting, we can now choose "Disabled" and everything will continue download / work fine as before? If yes, what would be the purpose of the ASN Reporting field, i.e. when it would be useful to still enable the cache setting? Could this field be removed altogether now that the switch IPinfo has occurred? Thanks in advance.

BBcan177 · Oct 19, 2024, 6:13 PM

@tman222

Yes you can set that to disabled and it will still download OK. That setting was more useful with BGPview, but I would still recommend to set it to atleasy 1 hour as it might give a small micro performance boost.

tman222 · Oct 19, 2024, 6:40 PM

@BBcan177 said in pfBlockerNG_devel commit reverse:

@tman222

Yes you can set that to disabled and it will still download OK. That setting was more useful with BGPview, but I would still recommend to set it to atleasy 1 hour as it might give a small micro performance boost.

Thanks @BBcan177. Since the IPinfo ASN data is updated only once every 24 hours, do you see any additional advantage to increasing that ASN cache setting from 1 hour to e.g. 4 or 12 hours? Thanks again.

TommyMoo · Oct 20, 2024, 8:06 PM

Updated pfBlocker devel from 3.2.0_19 to 3.2.0_20 ..all good (on x86 qemu), GEOIP / ASN entrys etc. all working well, Thank you for the Update!