BOUNTY: Web GUI reprogramming

charlie0440 · May 26, 2013, 4:57 PM

@clear-pixel Don't think you read the last few posts before posting. I solved that problem of storing the column number a few posts back.

I hear what your saying about the GUI. I think the way to go is to get all the css and as much js as we can out of the HTML/PHP pages and into .css & .js files. Then we can work on stuff like collapsible menus and fancy stuff. But until that is done, it would be a nightmare.

stephenw10 · May 26, 2013, 5:55 PM

I would personally not want collapsible menus unless there was a very good reason for it. I can't think of one, but I'm open to suggestions. ;)

Steve

Supermule · May 26, 2013, 6:49 PM

I think the one we have now is fine like in the pfsense_ng theme.

Its just the number of columns, drag and drop and especially the save issue that bothers me.

Clear-Pixel · May 26, 2013, 6:50 PM

@stephenw10:

I would personally not want collapsible menus unless there was a very good reason for it. I can't think of one, but I'm open to suggestions. ;)

Steve

The majority want and understand the purpose of collapsible menus.

charlie0440 · May 26, 2013, 6:55 PM

@supermule have you tried my theme?

stephenw10 · May 26, 2013, 10:32 PM

Perhaps I've misunderstood. Like I said I'm open to suggestions.

Steve

Supermule · May 27, 2013, 6:03 AM

Not yet Charlie.

Been busy as fook!

@charlie0440:

@supermule have you tried my theme?

c0urier · May 28, 2013, 12:24 PM

@charlie0440:

if anyone wants to test it. Download it here: https://dl.dropboxusercontent.com/u/12367642/full_screen_theme.zip

extract the zip to a folder ie tmp

you need to place the files onto pfsense.

In linux from a terminal:
cd /location/of/folder/tmp
scp -r * root@192.168.0.50:/usr/local/www/

Remeber to change the ip address ;)

Then on the webgui select the theme full_screen

Edit for 2.1 only (not sure if it'll work with 2.0.x)

I tried the following and am able to create extra coloums, but I am not able to save them. As soon as I hit "Save Settings" it jumps back to default two coloums.
I have cleared cache/cookies etc. does not chance anything, any advice would be greatly appreciated.

Supermule · May 28, 2013, 12:49 PM

The columns are hard coded into PFSense. Unfortunately….

charlie0440 · May 28, 2013, 1:03 PM

@Supermule:

The columns are hard coded into PFSense. Unfortunately….

This is easily amended without breaking or effecting any code. See my changes here especially the comments : https://github.com/CharlieMarshall/pfsense/commit/93916e320f6d0a7cfc1cf884a73e93cfe1c7f99c

@c0urier:

I tried the following and am able to create extra coloums, but I am not able to save them. As soon as I hit "Save Settings" it jumps back to default two coloums.
I have cleared cache/cookies etc. does not chance anything, any advice would be greatly appreciated.

Interesting it works perfect here. Are you trying to save with an empty column? What happens if you add a new column and add a widget to that columns so you have at least one widget in each columns and click save. Which version of pfsense are you using, 2.0 or 2.1?

Edit - I changed the zip file I linked to yesterday. The one you downloaded was it called full_screen.zip or full_screen_theme.zip ?

Edit 2 - Need more testers. Can anyone else try this ?

c0urier · May 28, 2013, 1:11 PM

I tried with and without Widgets, with 1 and 3 widgets - no Changes.

I'm Running 2.1-RC0.

~~full_screen.zip was the one I downloaded.~~ full_screen_theme.zip

charlie0440 · May 28, 2013, 1:07 PM

re download from the link. It should be called full_screen_theme.zip and report back

c0urier · May 28, 2013, 1:15 PM

Tested again after having downloaded the package. It's the same result.

charlie0440 · May 28, 2013, 1:49 PM

hmm i'll have to investigate further. Just downloading the latest snapshot to check there hasn't been a change that is affecting it. I am currently running a build from 17th May.

Again can anyone else test this out?

Edit - Works fine for me on 28th May snapshot

c0urier · May 28, 2013, 4:37 PM

My exact version is:
2.1-RC0 (amd64)
built on Thu May 23 20:43:32 EDT 2013
FreeBSD 8.3-RELEASE-p8

Clear-Pixel · May 28, 2013, 8:46 PM

@charlie0440:

@clear-pixel Don't think you read the last few posts before posting. I solved that problem of storing the column number a few posts back.

I hear what your saying about the GUI. I think the way to go is to get all the css and as much js as we can out of the HTML/PHP pages and into .css & .js files. Then we can work on stuff like collapsible menus and fancy stuff. But until that is done, it would be a nightmare.

Do you think, or do you know you fixed it?

charlie0440 · May 29, 2013, 9:22 AM

~~Well it works fine on my setup but appears not to be working for c0urier. Perhaps you could test it too?~~

Edit - Yes it works

stephenw10 · May 29, 2013, 8:43 AM

Maybe a 32bit/64bit issue? Is there anything compiled in there?

It works fine for me on a 32bit nano install, a few ~~days~~ weeks old though:

2.1-BETA1 (i386)
built on Wed May 15 13:19:07 EDT 2013

Looks good. :)

Steve

charlie0440 · May 29, 2013, 9:21 AM

Thanks for testing Stephen.

~~Its odd it's not working for c0urier as the only changes are a few lines to the index.php and some added Jquery to a javascript file.

@c0urier I pm'd you~~

c0urier · May 29, 2013, 9:17 AM

The index.php file was located in /usr/local/www/themes for some reason.
But I can't explain why it ended there as it asked to overwrite index.php.

It works now, thanks!