Unbound TCP buffer settings not sticky

[wagonza]

@markn62 - ive made some changes which should make these options stick. Let me know if it works for you.

[markn62]

Presume I would need to apply a snapshot.  Is the snapshot dated today?

[wagonza]

Nope - just update your Unbound package.

[markn62]

Thanks I'll check and report back.

[doktornotor]

I guess something got broken here on the way? On trying to save advanced settings I get

The following input errors were detected:

You must enter a valid number in 'TTL for lame delegation'.

[wagonza]

Fixed. Reinstall :/

[doktornotor]

@wagonza:

Reinstall :/

Hehe, I'll cron an hourly reinstall I guess. :D

Fixed, thanks again!  8)

[wagonza]

@doktornotor:

Hehe, I'll cron an hourly reinstall I guess. :D

Ha! Cool thanks for the feedback.

[markn62]

Upgraded the service watchdog package fine.  Then went onto the unbound upgrade and it failed.  Now I get "Unable to retrieve package info from www.pfsense.com. Cached data will be used" which doesn't get me anywhere.

[markn62]

First attempt at a package upgrade failed.  Had to reboot pfsense then the unbound version 1.4.21_3 package would install. Go figure.

In the GUI I changed both "incoming TCP buffers" and "outgoing TCP buffers" from 10 to zero and /usr/pbi/unbound-amd64/etc/unbound/unbound.conf reports;

outgoing-num-tcp: 10
incoming-num-tcp: 10

So no change that I can see.

[wagonza]

Thanks for the feedback. Found the problem and fixed.

[markn62]

When do you plan to release the fix?

[wagonza]

Its released so you just need to reinstall the package. I didnt bump the version.

[markn62]

Ahhh, didn't know I could PKG from the "installed packages" tab.  I'll report back by tomorrow.

[shinzo]

After installing unbound 1.4.21_3 none of the custom options i am using seem to work anymore.  The error is

php: config.inc: The command '/usr/pbi/unbound-amd64/sbin/unbound-control start' returned exit code '1', the output was '/usr/pbi/unbound-amd64/etc/unbound/unbound.conf:104: error: syntax error read /usr/pbi/unbound-amd64/etc/unbound/unbound.conf failed: 1 errors in configuration file [1393437916] unbound[79295:0] fatal error: Could not read config file: /usr/pbi/unbound-amd64/etc/unbound/unbound.conf'

When i went into the file it starts on the first line of the custom options, if i remove all the options i have it will boot fine.

"msg-cache-slabs: 1;rrset-cache-slabs: 1;infra-cache-slabs: 1;key-cache-slabs: 1;outgoing-range: 950;val-clean-additional: yes;harden-glue: yes;do-not-query-localhost: yes;do-ip6: no;use-caps-for-id: no;hide-identity: yes;hide-version: yes"

the custom options i was using.  I even tried using them one at a time and it still give me the errors.

[bryan.paradis]

@shinzo:

After installing unbound 1.4.21_3 none of the custom options i am using seem to work anymore.  The error is

php: config.inc: The command '/usr/pbi/unbound-amd64/sbin/unbound-control start' returned exit code '1', the output was '/usr/pbi/unbound-amd64/etc/unbound/unbound.conf:104: error: syntax error read /usr/pbi/unbound-amd64/etc/unbound/unbound.conf failed: 1 errors in configuration file [1393437916] unbound[79295:0] fatal error: Could not read config file: /usr/pbi/unbound-amd64/etc/unbound/unbound.conf'

When i went into the file it starts on the first line of the custom options, if i remove all the options i have it will boot fine.

"msg-cache-slabs: 1;rrset-cache-slabs: 1;infra-cache-slabs: 1;key-cache-slabs: 1;outgoing-range: 950;val-clean-additional: yes;harden-glue: yes;do-not-query-localhost: yes;do-ip6: no;use-caps-for-id: no;hide-identity: yes;hide-version: yes"

the custom options i was using.  I even tried using them one at a time and it still give me the errors.

The options in the configuration file should be like below

option: blah
option: blah
option: blah

the gui should take the custom options then split them by the delimiter ; then it puts them on a new line for each option

	# Handle custom options
	if (!empty($adv_config['custom_options'])) {
		$custom_options = explode(";", ($adv_config['custom_options']));
		$unbound_conf .= "\n# Unbound Custom options\n";
		foreach ($custom_options as $ent)
			$unbound_conf .= $ent."\n";

Is that the line you see exactly in your config file? What are you putting in the advanced options form in the gui?

[shinzo]

@bryan.paradis:

@shinzo:

After installing unbound 1.4.21_3 none of the custom options i am using seem to work anymore.  The error is

php: config.inc: The command '/usr/pbi/unbound-amd64/sbin/unbound-control start' returned exit code '1', the output was '/usr/pbi/unbound-amd64/etc/unbound/unbound.conf:104: error: syntax error read /usr/pbi/unbound-amd64/etc/unbound/unbound.conf failed: 1 errors in configuration file [1393437916] unbound[79295:0] fatal error: Could not read config file: /usr/pbi/unbound-amd64/etc/unbound/unbound.conf'

When i went into the file it starts on the first line of the custom options, if i remove all the options i have it will boot fine.

"msg-cache-slabs: 1;rrset-cache-slabs: 1;infra-cache-slabs: 1;key-cache-slabs: 1;outgoing-range: 950;val-clean-additional: yes;harden-glue: yes;do-not-query-localhost: yes;do-ip6: no;use-caps-for-id: no;hide-identity: yes;hide-version: yes"

the custom options i was using.  I even tried using them one at a time and it still give me the errors.

The options in the configuration file should be like below

option: blah
option: blah
option: blah

the gui should take the custom options then split them by the delimiter ; then it puts them on a new line for each option

	# Handle custom options
	if (!empty($adv_config['custom_options'])) {
		$custom_options = explode(";", ($adv_config['custom_options']));
		$unbound_conf .= "\n# Unbound Custom options\n";
		foreach ($custom_options as $ent)
			$unbound_conf .= $ent."\n";

Is that the line you see exactly in your config file? What are you putting in the advanced options form in the gui?

I looked over the code and it is the same.  In the advanced options in the gui i have

"msg-cache-slabs: 1;rrset-cache-slabs: 1;infra-cache-slabs: 1;key-cache-slabs: 1;outgoing-range: 950;val-clean-additional: yes;harden-glue: yes;do-not-query-localhost: yes;do-ip6: no;use-caps-for-id: no;hide-identity: yes;hide-version: yes"  as the semi colon is used to make a new line.

when i go into the config file, it is being set correctly.

Unbound Custom options

msg-cache-slabs: 1
rrset-cache-slabs: 1
infra-cache-slabs: 1
key-cache-slabs: 1
outgoing-range: 950
val-clean-additional: yes
harden-glue: yes
do-not-query-localhost: yes
do-ip6: no
use-caps-for-id: no
hide-identity: yes
hide-version: yes

[markn62]

@Shinzo,
What version package were you running prior?  I can tell you outgoing-range as a custom setting, along with a few select others, has never worked in 2.0 or 2.1, see my post @ https://forum.pfsense.org/index.php/topic,64897.msg352131.html#msg352131 .  I had to strip my custom options down to only forward zone and addresses.  No way to detune unbound.  So you cant really troubleshoot the package by probable trial'n'error if it acts quirky.  Unbound reboots by itself a few times a day on my 64-bit install.  And I've never read anywhere until today that the word "option:" needs to be placed before every custom option entry if I read this thread correctly.  Where is this documented?  I don't use them in my options and the ones I have entered show in the unbound.conf fine.  Can't say if, for example, "option: outgoing-range: 950" would be accepted by unbound but imagine it would get hung up on the pair of colon syntax, although I haven't tried it.

[shinzo]

@markn62:

@Shinzo,
What version package were you running prior?  I can tell you outgoing-range as a custom setting, along with a few select others, has never worked in 2.0 or 2.1, see my post @ https://forum.pfsense.org/index.php/topic,64897.msg352131.html#msg352131 .  I had to strip my custom options down to only forward zone and addresses.  No way to detune unbound.  So you cant really troubleshoot the package by probable trial'n'error if it acts quirky.  Unbound reboots by itself a few times a day on my 64-bit install.  And I've never read anywhere until today that the word "option:" needs to be placed before every custom option entry if I read this thread correctly.  Where is this documented?  I don't use them in my options and the ones I have entered show in the unbound.conf fine.  Can't say if, for example, "option: outgoing-range: 950" would be accepted by unbound but imagine it would get hung up on the pair of colon syntax, although I haven't tried it.

The "option: blah"  was used as a example of how the output should be.  As i continue to troubleshoot my issue, i removed the 4 previous lines which had to do with the forward-zones and got it up and running, il keep looking

oh and i was using version 1.4.21_2 and it was on a 2.1.1 box

[bryan.paradis]

FILE FORMAT
      There  must be whitespace between keywords. Attribute keywords end with
      a colon ':'. An attribute is followed by its containing attributes,  or
      a value.

Files  can be included using the include: directive. It can appear any-
      where, it accepts a single file name as argument.  Processing continues
      as  if  the text from the included file was copied into the config file
      at that point.  If also using chroot, using full path  names  for  the
      included files works, relative pathnames for the included names work if
      the directory where the daemon is  started  equals  its chroot/working
      directory.  Wildcards  can  be used  to  include  multiple files, see
      glob(7).

Server Options
      These options are part of the server: clause.

Looks like the configuration file should be laid out in clause sections full of options as below:

server:
option: blah

remote-control:
option: blah

stub-zone:
option: blah

forward-zone:
option: blah

but it seems that the custom server options are being added after the forward-zone clause. I have moved the code in the unbound.inc file up above the foward-zone code and attached it. Try backing up the unbound.inc and placing the one I have attached in its place.

unbound.inc.txt