@vbentley:
Do you have a public or private IP address on your WAN interface now?
It is usual to have to configure the ADSL router to change from routing to bridging before PPPoE will work.
I now have a public IP on the WAN interface, apparently these devices are configured in 'DHCP Passthrough' mode so it acts as a modem and then passes the connection specific configuration (IP, GW, DNS etc) through to the 'cable' router via DHCP.