Limiter error

xbipin

when u add a new limiter, the + button doesnt work and when the mouse is on it shows some html code, screenshot below

Untitled.jpg_thumb

xbipin

it seems the Tue Oct 9 01:55:21 EDT 2012 snapshot has limiter working fine but just deleting a limiter gives the below error but the snaps after that date have limiter broken

Fatal error: Call to undefined method dnpipe_class::GetName() in /usr/local/www/firewall_shaper_vinterface.php on line 101

phil.davis

I have all the problems above. Some systems on Wed Oct 10 18:45:43 EDT 2012 and some on Thu Oct 11 18:34:41 EDT 2012 - both have the problem. I had clients from my general DHCP pool matching a limiter to to limit the bandwidth of general "unknown" visitors, phones etc. I had to disable any limiter rules to get the clients functioning from those DHCP pool addresses.
I am trying to add a limiter on a test system so I can see what the problems are, but I can't even do that because the "+" button to add a badnwidth on a new limiter does not do anyhting, as xbipin says.
https://github.com/bsdperimeter/pfsense/commit/c9ba2f8a92b0e18b891af2049436d4a3a505f9d9 made lots of changes/enhancements to the limiter code. I will have a look to see if there is an obvious typo bug, but it would be really good if the originator can test and fix this stuff. It should be quite easy to load the current snapshot and see the issues above.

phil.davis

Made a pull request to fix the mouseover rubbish (code) in the popup. This also makes the Mask field appear again on the GUI, rather than being text in the mouseover popup.
I can't see quickly how to make the "+" button give a new/first row when creating a new limiter - hopefully Ermal will look soon and fix it.
The pf rule generation seems to have broken due to line 2970 of shaper.inc getting deleted:

$pfq_rule = "\npipe ". $this->GetNumber() . " config ";

It would become line 3001 when inserted back into the new version of shaper.inc
I don't have a suitable system to test this on right away - if someone wants to look at my comment on the original commit and try putting this line back, then please test my theory.

xbipin

i tried that line of code and it makes it work partially, the limiter info page atleast doesn't say limiter not found and the reason for that is with that line of code the /tmp/rules.limiter file gets written so limiter comes in action but the problem is its not writing out the config of the limiter properly, below r the contents of another system from 9th October where limiter works and another where with that line of code the config is working but not limiting traffic due to broken config file

working config file


pipe 1 config  bw 1Kb

broken config file


pipe 1 config 

pipe 2 config 

pipe 3 config 

pipe 4 config 

pipe 5 config 

pipe 6 config

xbipin

found one more bug which can be fixed to make that + button work partially, there is one ' missing in etc/inc/shaper.inc

change the below

$form .= "![](/themes/{$g[ "" . gettext("add another schedule") . "/></a>";</pre><br /><br />to<br /><pre>$form .= "<img border=")";

this will fix adding more schdule button action only when u have one entry already existing but will not work if u create a fresh entry and then click +

phil.davis

I put in a pull request to fix this a couple of days ago, but noone has committed it. I notice that Ermal has just fixed up a line that was accidentally deleted in his commit. Perhaps he will look at the other bugs in this soon and get it sorted. I really don't want to do any upgrades until there is a good looking set of fixes to test.

xbipin

insipte of that bug, limiter config is still not written out properly for it to work so needs more work on the shaper.inc file

it seems the config is only written out properly when there is a limiter and schedule is not set to none

xanaro

@xbipin:

it seems the Tue Oct 9 01:55:21 EDT 2012 snapshot has limiter working fine but just deleting a limiter gives the below error but the snaps after that date have limiter broken
Fatal error: Call to undefined method dnpipe_class::GetName() in /usr/local/www/firewall_shaper_vinterface.php on line 101 

I do not see an Oct 9 snapshot, with a time stamp of 01:55:21 listed, it only goes back as far as 02:21, so it seems only X number of revisions are stored on http://snapshots.pfsense.org

Is there any other mirror I can use to download an older snapshot iso?

I need to use the 2.1 Snapshot because it resolves a state clearing issue with my asterisk VOIP pc: http://forum.pfsense.org/index.php/topic,43112.msg289336.html#msg289336

We have 5 users on our home network and 4 of them like to use netflix and youtube, sometimes concurrently. and our residential connection is only 10 Mbit, when they are doing this the lag gets pretty bad. I was using the limiter to limit traffic on port 80 to 7Mbit, which pretty much solved all our issues.

So if anyone knows where I can download an older snapshot please let me know, or if you could please upload the "Tue Oct 9 01:55:21 EDT 2012 snapshot" or an older one, anywhere like rapidshare or whatever, if you still have the iso file on your computer.

I would greatly appreciate it.

Thank you so much :)

xbipin

try the next snap currently being built, should be ready in an hour or 2, should solve limiter error to some extent, bear in mind, u will need to assign some schedule to each limiter for it to work as of now until the remaining bugs r fixed

xanaro

Thanks for the reply, I updated, now I am on:

2.1-BETA0 (i386)
built on Thu Oct 18 09:03:11 EDT 2012
FreeBSD 8.3-RELEASE-p4

The place where there used to be a field to enter an amount of bandwidth, the only thing there now is a "+" button and when you hover over it, the tooltip shows "add another schedule" clicking this button does nothing, as if the button is not working.

before trying to click the button I created a schedule under firewall -> schedules and just selected the rest of the days for october with a time of 00:00-23:59 and saved it.

xbipin

yes its a known issue, the developers should fix it once they figure it out

phil.davis

It is still not possible to enter a new limiter, because the Bandwidth "+" button does not make a new empty row.
Is anyone who knows about the limiter code able to look at and fix this?

limiter.png_thumb

jimp

Ermal should be back from EuroBSDCon in a day or two, once he's back he can get it fixed up.

bardelot

The JavaScript was missing. I made a patch that adds it. (https://github.com/bsdperimeter/pfsense/pull/241)
You can also manually apply the patch and report if everything is working afterwards.

jimp

Merged it in.

eri--

Next snapshots should have limiters back and working with and without schedules.

phil.davis

2.1-BETA0 (i386)
built on Tue Oct 23 20:55:01 EDT 2012
I can add new limiters, with and without schedules, put them in rules, apply them and they work.
No PHP errors, no errors in the system log.
Looks good - for those who need limiters and are waiting to update, this snapshot seems like a good thing.
Thanks Ermal.

xbipin

i can also confirm the same, its working fine, need to check schedules overlap situation

eri--

The first in line wins, that is the behaviour.