Netgate Discussion Forum
    • Categories
    • Recent
    • Tags
    • Popular
    • Users
    • Search
    • Register
    • Login

    Limiter error

    Scheduled Pinned Locked Moved 2.1 Snapshot Feedback and Problems - RETIRED
    35 Posts 6 Posters 9.7k Views
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • X
      xbipin
      last edited by

      found one more bug which can be fixed to make that + button work partially, there is one ' missing in etc/inc/shaper.inc

      change the below

      $form .= "![](/themes/{$g[ "" . gettext("add another schedule") . "/></a>";</pre><br /><br />to<br /><pre>$form .= "<img border=")";
      

      this will fix adding more schdule button action only when u have one entry already existing but will not work if u create a fresh entry and then click +

      1 Reply Last reply Reply Quote 0
      • P
        phil.davis
        last edited by

        I put in a pull request to fix this a couple of days ago, but noone has committed it. I notice that Ermal has just fixed up a line that was accidentally deleted in his commit. Perhaps he will look at the other bugs in this soon and get it sorted. I really don't want to do any upgrades until there is a good looking set of fixes to test.

        As the Greek philosopher Isosceles used to say, "There are 3 sides to every triangle."
        If I helped you, then help someone else - buy someone a gift from the INF catalog http://secure.inf.org/gifts/usd/

        1 Reply Last reply Reply Quote 0
        • X
          xbipin
          last edited by

          insipte of that bug, limiter config is still not written out properly for it to work so needs more work on the shaper.inc file

          it seems the config is only written out properly when there is a limiter and schedule is not set to none

          1 Reply Last reply Reply Quote 0
          • xanaroX
            xanaro
            last edited by

            @xbipin:

            it seems the Tue Oct 9 01:55:21 EDT 2012 snapshot has limiter working fine but just deleting a limiter gives the below error but the snaps after that date have limiter broken

            Fatal error: Call to undefined method dnpipe_class::GetName() in /usr/local/www/firewall_shaper_vinterface.php on line 101 
            

            I do not see an Oct 9 snapshot, with a time stamp of 01:55:21 listed, it only goes back as far as 02:21, so it seems only X number of revisions are stored on http://snapshots.pfsense.org

            Is there any other mirror I can use to download an older snapshot iso?

            I need to use the 2.1 Snapshot because it resolves a state clearing issue with my asterisk VOIP pc: http://forum.pfsense.org/index.php/topic,43112.msg289336.html#msg289336

            We have 5 users on our home network and 4 of them like to use netflix and youtube, sometimes concurrently. and our residential connection is only 10 Mbit, when they are doing this the lag gets pretty bad. I was using the limiter to limit traffic on port 80 to 7Mbit, which pretty much solved all our issues.

            So if anyone knows where I can download an older snapshot please let me know, or if you could please upload the "Tue Oct 9 01:55:21 EDT 2012 snapshot" or an older one, anywhere like rapidshare or whatever, if you still have the iso file on your computer.

            I would greatly appreciate it.

            Thank you so much :)

            1 Reply Last reply Reply Quote 0
            • X
              xbipin
              last edited by

              try the next snap currently being built, should be ready in an hour or 2, should solve limiter error to some extent, bear in mind, u will need to assign some schedule to each limiter for it to work as of now until the remaining bugs r fixed

              1 Reply Last reply Reply Quote 0
              • xanaroX
                xanaro
                last edited by

                Thanks for the reply, I updated, now I am on:

                2.1-BETA0 (i386)
                built on Thu Oct 18 09:03:11 EDT 2012
                FreeBSD 8.3-RELEASE-p4

                The place where there used to be a field to enter an amount of bandwidth, the only thing there now is a "+" button and when you hover over it, the tooltip shows "add another schedule" clicking this button does nothing, as if the button is not working.

                before trying to click the button I created a schedule under firewall -> schedules and just selected the rest of the days for october with a time of 00:00-23:59 and saved it.

                1 Reply Last reply Reply Quote 0
                • X
                  xbipin
                  last edited by

                  yes its a known issue, the developers should fix it once they figure it out

                  1 Reply Last reply Reply Quote 0
                  • P
                    phil.davis
                    last edited by

                    It is still not possible to enter a new limiter, because the Bandwidth "+" button does not make a new empty row.
                    Is anyone who knows about the limiter code able to look at and fix this?

                    limiter.png
                    limiter.png_thumb

                    As the Greek philosopher Isosceles used to say, "There are 3 sides to every triangle."
                    If I helped you, then help someone else - buy someone a gift from the INF catalog http://secure.inf.org/gifts/usd/

                    1 Reply Last reply Reply Quote 0
                    • jimpJ
                      jimp Rebel Alliance Developer Netgate
                      last edited by

                      Ermal should be back from EuroBSDCon in a day or two, once he's back he can get it fixed up.

                      Remember: Upvote with the šŸ‘ button for any user/post you find to be helpful, informative, or deserving of recognition!

                      Need help fast? Netgate Global Support!

                      Do not Chat/PM for help!

                      1 Reply Last reply Reply Quote 0
                      • B
                        bardelot
                        last edited by

                        The JavaScript was missing. I made a patch that adds it. (https://github.com/bsdperimeter/pfsense/pull/241)
                        You can also manually apply the patch and report if everything is working afterwards.

                        1 Reply Last reply Reply Quote 0
                        • jimpJ
                          jimp Rebel Alliance Developer Netgate
                          last edited by

                          Merged it in.

                          Remember: Upvote with the šŸ‘ button for any user/post you find to be helpful, informative, or deserving of recognition!

                          Need help fast? Netgate Global Support!

                          Do not Chat/PM for help!

                          1 Reply Last reply Reply Quote 0
                          • E
                            eri--
                            last edited by

                            Next snapshots should have limiters back and working with and without schedules.

                            1 Reply Last reply Reply Quote 0
                            • P
                              phil.davis
                              last edited by

                              2.1-BETA0 (i386)
                              built on Tue Oct 23 20:55:01 EDT 2012
                              I can add new limiters, with and without schedules, put them in rules, apply them and they work.
                              No PHP errors, no errors in the system log.
                              Looks good - for those who need limiters and are waiting to update, this snapshot seems like a good thing.
                              Thanks Ermal.

                              As the Greek philosopher Isosceles used to say, "There are 3 sides to every triangle."
                              If I helped you, then help someone else - buy someone a gift from the INF catalog http://secure.inf.org/gifts/usd/

                              1 Reply Last reply Reply Quote 0
                              • X
                                xbipin
                                last edited by

                                i can also confirm the same, its working fine, need to check schedules overlap situation

                                1 Reply Last reply Reply Quote 0
                                • E
                                  eri--
                                  last edited by

                                  The first in line wins, that is the behaviour.

                                  1 Reply Last reply Reply Quote 0
                                  • X
                                    xbipin
                                    last edited by

                                    one problme i noticed that when a schedule expires the config file ends up like this and that client looses complete internet access

                                    
                                    pipe 5 config 
                                    

                                    isnt it better to skip the whole line only so his connectivity doesnt break

                                    1 Reply Last reply Reply Quote 0
                                    • X
                                      xbipin
                                      last edited by

                                      also noticed with 6th nov snap that if u have a limiter and schedule set to none then it results in this config and doesnt limit anything

                                      pipe 5 configĀ  bw 120Kb bw 0
                                      
                                      1 Reply Last reply Reply Quote 0
                                      • E
                                        eri--
                                        last edited by

                                        Should be fixed on next snapshot.

                                        Thank you for reporting it.

                                        1 Reply Last reply Reply Quote 0
                                        • X
                                          xbipin
                                          last edited by

                                          @ermal:

                                          Should be fixed on next snapshot.

                                          Thank you for reporting it.

                                          tried the snap after the patch but still same, config shows as below and limiter doesnt limit with schedule set as none

                                          pipe 5 configĀ  bw 120Kb bw 0
                                          
                                          pipe 6 configĀ  bw 400Kb bw 0
                                          
                                          1 Reply Last reply Reply Quote 0
                                          • E
                                            eri--
                                            last edited by

                                            You really should have a strange config.xml there.
                                            I pushed another tuning to the code so test that out.

                                            1 Reply Last reply Reply Quote 0
                                            • First post
                                              Last post
                                            Copyright 2025 Rubicon Communications LLC (Netgate). All rights reserved.