error on add host override to dns forwarder

amcusack

error pops up when trying to add host override to dns forwarder

Fatal error: Uncaught TypeError: Cannot access offset of type string on string in /usr/local/www/services_dnsmasq_edit.php:154 Stack trace: #0 {main} thrown in /usr/local/www/services_dnsmasq_edit.php on line 154 PHP ERROR: Type: 1, File: /usr/local/www/services_dnsmasq_edit.php, Line: 154, Message: Uncaught TypeError: Cannot access offset of type string on string in /usr/local/www/services_dnsmasq_edit.php:154 Stack trace: #0 {main} thrown

I was able to add some after initial upgrade to 23.01 (yesterday), but can't add any more today

amcusack

extra info just popped up

Crash report begins.  Anonymous machine information:

amd64
14.0-CURRENT
FreeBSD 14.0-CURRENT #0 plus-devel-main-n255994-d894b4aac11: Fri Dec 16 06:30:06 UTC 2022     root@freebsd:/var/jenkins/workspace/pfSense-Plus-snapshots-master-main/obj/amd64/5QbEYaBj/var/jenkins/workspace/pfSense-Plus-snapshots-master-main/sources/FreeBS

Crash report details:

PHP Errors:
[18-Dec-2022 11:32:21 Australia/Adelaide] PHP Fatal error:  Uncaught TypeError: Cannot access offset of type string on string in /usr/local/www/services_dnsmasq_edit.php:154
Stack trace:
#0 {main}
  thrown in /usr/local/www/services_dnsmasq_edit.php on line 154
[18-Dec-2022 11:32:46 Australia/Adelaide] PHP Fatal error:  Uncaught TypeError: Cannot access offset of type string on string in /usr/local/www/services_dnsmasq_edit.php:154
Stack trace:
#0 {main}
  thrown in /usr/local/www/services_dnsmasq_edit.php on line 154
[18-Dec-2022 11:38:10 Australia/Adelaide] PHP Fatal error:  Uncaught TypeError: Cannot access offset of type string on string in /usr/local/www/services_dnsmasq_edit.php:154
Stack trace:
#0 {main}
  thrown in /usr/local/www/services_dnsmasq_edit.php on line 154



No FreeBSD crash data found.

jimp

Interesting, you must have an entry with a weird empty "alias" tag on it in your existing mappings in the config.

Can you share the dns forwarder section of your config? You can sanitize names and addresses by replacing characters but please leave some kind of content in all the fields that actually have content in them.

stephenw10

I replicated this with an empty DNSMasq config, imediately after enabling and trying to add a forward:

PHP ERROR: Type: 1, File: /usr/local/www/services_dnsmasq_edit.php, Line: 154, Message: Uncaught TypeError: Cannot access offset of type string on string in /usr/local/www/services_dnsmasq_edit.php:154
Stack trace:
#0 {main}
thrown @ 2022-12-19 22:59:57

	<dnsmasq>
		<enable></enable>
		<interface></interface>
	</dnsmasq>

https://redmine.pfsense.org/issues/13781

amcusack

@jimp said in error on add host override to dns forwarder:

Can you share the dns forwarder section of your config? You can sanitize names and addresses by replacing characters but please leave some kind of content in all the fields that actually have content in them.

Sorry, no can do, I deleted the dns forwarder config & changed to the dns resolver (in forwarding mode)

stephenw10

Unbound in forwarding mode is usually a better choice anyway.

This will be fixed in tomorrows build though.