Testing Needed: AutoConfigBackup Package


  • Rebel Alliance Developer Netgate

    I committed a Bootstrap-converted version of the package this afternoon and it seems to work well for me on multiple test firewalls with multiple accounts.

    If you have a Gold Subscription, please install the package on 2.3 and configure it and give it a test. Thanks!



  • When I do a manual backup with ACB it seems to save twice.

    Settings tab has no breadcrumbs - the other tabs do.

    At the bottom it says:
    "Click the + sign next to the revision to restore."

    But the restore icon is now a different reverse circular arrow.



  • Banned

    @phil.davis:

    When I do a manual backup with ACB it seems to save twice.

    Well, that's always been the case for me even with 2.2.x; frankly, MOST of the config changes are getting saved twice everywhere with ACB (have this running on 5 boxes).

    On another note - unrelated, but… why there's no default save text for packages, that'd include the package name? Have two shittons of "Unknown reason specified" items in history is not exactly useful.  >:(



  • On another note - unrelated, but… why there's no default save text for packages, that'd include the package name? Have two shittons of "Unknown reason specified" items in history is not exactly useful.

    For most changes "the system" knows exactly what it is doing. There could be a general project to make all the write_config() calls have more detailed text so that better descriptions get saved.


  • Rebel Alliance Developer Netgate

    @phil.davis:

    When I do a manual backup with ACB it seems to save twice.

    That's always been the case, not sure if there is a good way around that. It saves the manual backup but that also triggers a config write first.

    @phil.davis:

    Settings tab has no breadcrumbs - the other tabs do.

    That's a larger issue with all packages that use XML settings. I think there is a separate ticket for it.

    @phil.davis:

    At the bottom it says:
    "Click the + sign next to the revision to restore."
    But the restore icon is now a different reverse circular arrow.

    I'll get that fixed up, must have missed it. :-)

    @phil.davis:

    On another note - unrelated, but… why there's no default save text for packages, that'd include the package name? Have two shittons of "Unknown reason specified" items in history is not exactly useful.

    For most changes "the system" knows exactly what it is doing. There could be a general project to make all the write_config() calls have more detailed text so that better descriptions get saved.

    It could perhaps be a bit smarter but that is really a much more involved topic than it seems. Probably past the time when we could do more than just some minor work on a project like that for 2.3. It's unrelated to ACB though so that should be its own thread/ticket.



  • breadcrumbs packages has an open PR: https://github.com/pfsense/pfsense/pull/2161


  • Rebel Alliance Developer Netgate

    I pushed some fixes for ACB just now:

    • Stopped the double backup when initiating a manual one
    • Fixed up the notice format, it changed slightly for 2.3 and it was coming through kind of ugly.
    • Fixed the help text to show the correct icon on the Restore tab


  • Looks good. I made a PR for a duplicated "an" in some text:
    https://github.com/pfsense/FreeBSD-ports/pull/11

    Happy to see the duplicated manual backups gone  :)


  • Rebel Alliance Developer Netgate

    I'll merge that in a moment, might wait to see if anything else turns up before I bump the Makefile. Unlike the old package database the new file contents aren't available until the version is bumped in the Makefile so a new package archive is built, so even minor changes like that require a bump to be activated.



  • Agree - I wouldn't be in a rush to release a tiny text change.


Log in to reply