It has been my experience that some major configuration changes to pfSense don't correctly clear the old values so that new values can properly take effect. I suggest you save (but not apply) the LAN IP subnet change then reboot for it to take effect.
@itson:
when i type the voucher it just seems like refreshes the page doesnt redirect and doesnt let me connect to the internet.
I would be helpful to know what the browser did do (for example, what was shown in the location bar? did the browser report a name resolution problem?) as well as what it didn't do.
@itson:
after trying to figure out what it could be and started getting calls from customers that they cant connect, i quickly had to change ip and dhcp ips back to 192.168.1.1 range
PERHAPS some of these customers still had DHCP leases for IP addresses in the 192.168.1.x range.
PERHAPS you needed to restart Captive Portal (Disable then enable) after the IP address change.