DNS Forwarder Custom Options always gives "Invalid custom options"

johnpoz

@blaize what exactly are you putting in because per the man page for dnsmaq

The optional string after the @ character tells dnsmasq how to set the source of the queries to this nameserver. It should be an ip-address

I set this and it works

blaize

@johnpoz

Man page says this:

--server=[/[<domain>]/[domain/]][<server>[#<port>]][@<interface>][@<source-ip>[#<port>]]

@interface is the name of the interface.

But that's not the problem. It doesn't matter what I put in. I get that "not valid" error message.

johnpoz

@blaize vtnet0 that is a proxmox thing is it not? That is sure not an interface name you would see on pfsense on hardware.

As @stephenw10 showed it works with that simple max-ttl=30 command.. And it works for me using your command and a source IP. Guess I could try it with the interface name.

So it is not working with interface name on 2.7.2, I tried with actual interface name em0, tried with LAN, etc. But that server option works just fine IP address. Possible pfsense is only parsing for IP and not the interface name?

But your saying you can not even get max-ttl=30 working. Where the option box is clear and and only the max-ttl=30 in there?

[2.7.2-RELEASE][admin@test.mydomain.tld]/root: ps -auxwd | grep dnsmasq
nobody  3335   0.0  0.5  17900  4568  -  I    23:16   0:00.00 |-- /usr/local/sbin/dnsmasq -C /dev/null --no-resolv --all-servers --max-ttl=30 --server=8.8.8.8@192.168.9.34 --dns-forward-max=5
root   55093   0.0  0.0    436   264  0  R+   23:17   0:00.00 |       `-- grep dnsmasq
[2.7.2-RELEASE][admin@test.mydomain.tld]/root:

I can't duplicate that problem, it works with max-ttl=30 no problem.. But yeah its not taking name for the interface, but it works with IP just fine.

Not sure why your having issues with just the max-ttl, I tried adding spaces in front, after and it still worked, blank line in front even. Your on 2.7.2 right.. Yeah that is what running test on..

Shows its running

[2.7.2-RELEASE][admin@test.mydomain.tld]/root: dnsmasq -v
Dnsmasq version 2.89  Copyright (c) 2000-2022 Simon Kelley

I tired running the command manually

[2.7.2-RELEASE][admin@test.mydomain.tld]/root: /usr/local/sbin/dnsmasq -C /dev/null --no-resolv --all-servers --max-ttl=30 --server=8.8.8.8@em0 --dns-forward-max=5

dnsmasq: bad command line options: interface binding not supported

And it doesn't like using name.. But if use IP it takes it

[2.7.2-RELEASE][admin@test.mydomain.tld]/root: /usr/local/sbin/dnsmasq -C /dev/null --no-resolv --all-servers --max-ttl=30 --server=8.8.8.8@192.168.9.34 --dns-forward-max=5
[2.7.2-RELEASE][admin@test.mydomain.tld]/root:

That sort of says it not just a parsing of the options box issue.

stephenw10

Mmm, that looks like the issue.

But even if it did work that option would simply tell dnsmasq to use em0 when connecting out to 8.8.8.8. It does not tell it to forward queries from em0 to 8.8.8.8.

johnpoz

@stephenw10 true, but just because option doesn't do what he thought it did is not really relevant to his issue. Curious what he has going on that he can't do max-ttl even? Unless he hasn't really tried that all by itself?

blaize

@johnpoz @stephenw10

I think it is a bug. I stopped the daemon in the UI and ran the command in the console like it supposed to be my adding --max-ttl to the command.

/usr/local/sbin/dnsmasq -C /dev/null --rebind-localhost-ok --stop-dns-rebind --no-resolv --server=2600:1701:44d:6000::1 --server=192.168.1.254 --all-servers --dns-forward-max=5000 --cache-size=10000 --local-ttl=1 --max-ttl=30

Works fine. Something about the UI is not taking that parameter. It does not appear to be an issue with dnsmasq per se, rather the UI/backend trying to validate the option before starting the daemon.

blaize

@johnpoz All that to say, the --server parameter is supposed to specify the upstream server for a filter (ip address, domain name, interface, etc.) while everything else is local unless you suppress it. According to the docs:

"Specify upstream servers directly. Setting this flag does not suppress reading of /etc/resolv.conf, use --no-resolv to do that. If one or more optional domains are given, that server is used only for those domains and they are queried only using the specified server. This is intended for private nameservers: if you have a nameserver on your network which deals with names of the form xxx.internal.thekelleys.org.uk at 192.168.1.1 then giving the flag --server=/internal.thekelleys.org.uk/192.168.1.1 will send all queries for internal machines to that nameserver, everything else will go to the servers in /etc/resolv.conf."

But as I said, my problem looks more like an issue with the UI itself. I'm not sure what's going on there.

stephenw10

What exactly does your custom options field look like? I can't replicate the issue here in 2.7.2.

johnpoz

@stephenw10 nor can I.. And I tried all kinds of weirdness in how I put max-ttl=30 in the box.. blank lines before it, spaces before and after it etc.. It always took it just fine.

blaize

@stephenw10 Here's the screenshots.

max-ttl=30.png max-ttl=30b.png

stephenw10

Hmm, some rogue character in there?

Some other odd combination of options?

What does it look like in the config:

	<dnsmasq>
		<enable></enable>
		<port>5353</port>
		<interface></interface>
		<custom_options>bWF4LXR0bD0zMA==</custom_options>
	</dnsmasq>

You probably don't have the custom options value as it sees it as invalid when adding it.

blaize

@stephenw10 It doesn't save it between attempts.

I thought it might be a random character or something like that, which is why I tried other browsers. It doesn't seem to be a browser issue though.

stephenw10

Then I can only imagine it's conflicting with some other option you have set.

Is that line you posted above the actual command that's run by your config?

blaize

@stephenw10

This is the generated line:

/usr/local/sbin/dnsmasq -C /dev/null --rebind-localhost-ok --stop-dns-rebind --no-resolv --server=2600:1701:44d:6000::1 --server=192.168.1.254 --all-servers --dns-forward-max=5000 --cache-size=10000 --local-ttl=1

This is the one I created:

/usr/local/sbin/dnsmasq -C /dev/null --rebind-localhost-ok --stop-dns-rebind --no-resolv --server=2600:1701:44d:6000::1 --server=192.168.1.254 --all-servers --dns-forward-max=5000 --cache-size=10000 --local-ttl=1 --max-ttl=30

Both of these work

The only thing difference is max-ttl. I don't think this has anything to do with dnsmasq.

johnpoz

@blaize said in DNS Forwarder Custom Options always gives "Invalid custom options":

The only thing difference is max-ttl. I don't think this has anything to do with dnsmasq.

That is a valid dnsmasq option

--max-ttl=<time>
Set a maximum TTL value that will be handed out to clients. The specified maximum TTL will be given to clients instead of the true TTL value if it is lower. The true TTL value is however kept in the cache to avoid flooding the upstream DNS servers.

dnsmasq --help | grep max-ttl
    --max-ttl=<integer>                                Specify time-to-live in seconds for maximum TTL to send to clients.

stephenw10

You have the <dnsmasq> config section generating that?

blaize

@johnpoz @stephenw10

It doesn't matter what I put in the text box. It gives me the error. I was using the max-ttl option just to eliminate the variables. I put it on the the command line to make sure it was not a problem with dnsmasq. It really seems like something between validation for the custom options and starting the daemon.

johnpoz

@blaize what do you show in the xml for dnsmasq - like @stephenw10 example above.

Antibiotic

@blaize The corresponding fix seems easy enough for a patch:

https://redmine.pfsense.org/projects/pfsense/repository/2/revisions/aac5bb5d396a1f1b18d59a532ad262a4d1085a40/diff

johnpoz

@Antibiotic said in DNS Forwarder Custom Options always gives "Invalid custom options":

ttps://redmine.pfsense.org/projects/pfsense/repository/2/revisions/aac5bb5d396a1f1b18d59a532ad262a4d1085a40/diff

huh - how is that related to reading a custom options entry? That is about domain overrides.