Netgate Discussion Forum
    • Categories
    • Recent
    • Tags
    • Popular
    • Users
    • Search
    • Register
    • Login

    On github, which branch to create pull requests against? I.e I'd like to add LDAP/AD nested group search as an option to an Authentication Server config.

    Scheduled Pinned Locked Moved Development
    3 Posts 2 Posters 264 Views
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • M
      maglub
      last edited by

      Hi,

      I've been poking around this forum a bit, but could not find the answer to my particular question.

      At the time being, we (in the shop I am at the moment) are running 2.4.4-RELEASE-p3, and I found a solution to a problem we have (concerning pfSense groups and nested Active Directory group membership) that I think is of interest for many other users.

      Given that I am super confident (well, one can never be), at least we can pretend I am, I am curious which branch I should create a pull request against?

      Should I send the pull request to the latest "RELENG_" release (which at the time of writing would be RELENG_2_4_4), and if it is accepted hope that it will be forward ported to the future 2.5?

      The reason for asking, is that I would like to see this feature in a minor patch as soon as possible. The question is generic, so I am not digging into the particulars about the feature I would like to patch.

      Have a nice day!
      //magnus

      1 Reply Last reply Reply Quote 0
      • kiokomanK
        kiokoman LAYER 8
        last edited by kiokoman

        always master (that would be 2.5.0 devel)
        you need to open a ticket at redmine.pfsense.org first (where you explain the problem) with a link to the PR
        they will eventually port it to 2.4.4 if they think it's worth/necessary/usefull

        https://docs.netgate.com/pfsense/en/latest/development/bug-reporting.html
        https://docs.netgate.com/pfsense/en/latest/development/requesting-new-pfsense-features.html

        ̿' ̿'\̵͇̿̿\з=(◕_◕)=ε/̵͇̿̿/'̿'̿ ̿
        Please do not use chat/PM to ask for help
        we must focus on silencing this @guest character. we must make up lies and alter the copyrights !
        Don't forget to Upvote with the 👍 button for any post you find to be helpful.

        1 Reply Last reply Reply Quote 0
        • M
          maglub
          last edited by

          Thanks!

          Now I also found the proper documentation for a pull request!

          https://docs.netgate.com/pfsense/en/latest/development/submitting-a-pull-request-via-github.html

          Have a nice day!
          //magnus

          1 Reply Last reply Reply Quote 0
          • First post
            Last post
          Copyright 2025 Rubicon Communications LLC (Netgate). All rights reserved.