On github, which branch to create pull requests against? I.e I'd like to add LDAP/AD nested group search as an option to an Authentication Server config.

[maglub]

Hi,

I've been poking around this forum a bit, but could not find the answer to my particular question.

At the time being, we (in the shop I am at the moment) are running 2.4.4-RELEASE-p3, and I found a solution to a problem we have (concerning pfSense groups and nested Active Directory group membership) that I think is of interest for many other users.

Given that I am super confident (well, one can never be), at least we can pretend I am, I am curious which branch I should create a pull request against?

Should I send the pull request to the latest "RELENG_" release (which at the time of writing would be RELENG_2_4_4), and if it is accepted hope that it will be forward ported to the future 2.5?

The reason for asking, is that I would like to see this feature in a minor patch as soon as possible. The question is generic, so I am not digging into the particulars about the feature I would like to patch.

Have a nice day!
//magnus

[kiokoman]

always master (that would be 2.5.0 devel)
you need to open a ticket at redmine.pfsense.org first (where you explain the problem) with a link to the PR
they will eventually port it to 2.4.4 if they think it's worth/necessary/usefull

https://docs.netgate.com/pfsense/en/latest/development/bug-reporting.html
https://docs.netgate.com/pfsense/en/latest/development/requesting-new-pfsense-features.html

[maglub]

Thanks!

Now I also found the proper documentation for a pull request!

https://docs.netgate.com/pfsense/en/latest/development/submitting-a-pull-request-via-github.html

Have a nice day!
//magnus