Msntp and DNS resolution

[Voami]

I've reviewed recent topics on problems with msntp. They suggest sticking with pool.ntp.org, but that other ntp servers should work if DNS resolution is working.

Environment
–----------------

• pfsense RC2

• Dual-wan configuration (inbound only)

• Internal DNS servers on LAN interface, configured on pfsense

Data
–-----

• Works fine with pool.ntp.org

• Does not work with 0.pool.ntp.org, or 0.us.pool.ntp.org, both of which resolve fine from the ping diagnostic tool within pfsense:

PING 0.us.pool.ntp.org (65.23.154.62) from my.ext.er.nal: 56 data bytes
64 bytes from 65.23.154.62: icmp_seq=0 ttl=53 time=78.383 ms
64 bytes from 65.23.154.62: icmp_seq=1 ttl=52 time=79.857 ms
64 bytes from 65.23.154.62: icmp_seq=2 ttl=52 time=79.405 ms

–- 0.us.pool.ntp.org ping statistics ---
3 packets transmitted, 3 packets received, 0% packet loss
round-trip min/avg/max/stddev = 78.383/79.215/79.857/0.617 ms

• Msntp errors in log every minute:

2006/08/24	19:03:14.04	M			<30>aug 24 19:03:11 msntp[18627]: msntp options: a=2 p=0 v=1 e=0.100 e=5.000 p=2147483647.000			
2006/08/24	19:03:14.05	M			<30>aug 24 19:03:11 msntp[18627]:     d=18000 c=5 x=18000 op=1 l=/var/run/msntp.pid f=/var/db/msntp.state pool.ntp.org 172.16.44.44 ntp1.sf-bay.org 0.us.pool.ntp.org			
2006/08/24	19:03:14.05	M			<30>aug 24 19:03:11 msntp[18627]: msntp: different parameters for restart			
2006/08/24	19:03:14.06	M			<30>aug 24 19:03:11 msntp[18627]: msntp: using ntp server pool.ntp.org (81.15.165.16)			
2006/08/24	19:03:14.06	M			<30>aug 24 19:03:11 msntp[18627]: msntp: using ntp server ntp.local (172.16.44.44)			
2006/08/24	19:03:14.09	M			<30>aug 24 19:03:11 msntp[18627]: msntp: using ntp server ntp1.sf-bay.org (192.83.249.28)			
2006/08/24	19:03:14.11	M			<30>aug 24 19:03:11 msntp[18627]: msntp: invalid ip number 0.us.pool.ntp.org		

• NTP server entries that come after a server that fails lookup are not checked (same list as immediately above, but with last two servers switched)

2006/08/24	19:01:58.94	M			<30>aug 24 19:01:56 msntp[18338]: msntp options: a=2 p=0 v=1 e=0.100 e=5.000 p=2147483647.000			
2006/08/24	19:01:58.94	M			<30>aug 24 19:01:56 msntp[18338]:     d=18000 c=5 x=18000 op=1 l=/var/run/msntp.pid f=/var/db/msntp.state pool.ntp.org 172.16.44.44 0.us.pool.ntp.org ntp1.sf-bay.org			
2006/08/24	19:01:58.98	M			<30>aug 24 19:01:56 msntp[18338]: msntp: different parameters for restart			
2006/08/24	19:01:58.98	M			<30>aug 24 19:01:56 msntp[18338]: msntp: using ntp server pool.ntp.org (216.52.237.153)			
2006/08/24	19:01:58.98	M			<30>aug 24 19:01:56 msntp[18338]: msntp: using ntp server ntp.local (172.16.44.44)			
2006/08/24	19:01:58.98	M			<30>aug 24 19:01:56 msntp[18338]: msntp: invalid ip number 0.us.pool.ntp.org	

Hypothesis:
–--------------
Even with DNS configured and working properly, msntp will not resolve a DNS name with more than three components

Some kind of parsing error maybe, that limits the input to three.dotted.components?

Thoughts?

[sullrich]

I just commited a fix to work around this bug.