Extra Bridge DHCP fields display on OpenVPN Server Edit

[phil.davis]

I remember someone mentioning this in another thread, and I can't see it right now and I suspect it will get lost in the noise of that thread anyway. So best for this UI issue to have a thread of its own.
After making an OpenVPN server tunnel (e.g. I did a Peer-to-Peer Shared Key), when you edit it, the GUI page displays the following non-relevant fields:
Bridge DHCP
Bridge Interface
Server Bridge DHCP Start
Server Brodge DHCP End

If you select "tap" mode, then "tun" mode again, the script bits that turn the display of these things on/off get activated, and the fields disappear.
Something in the activation of the OpenVPN server edit page now doesn't do the cdode to switch on/off relevant fields. It works when first adding a new server. I'm sure a few weeks ago it worked when editing. I had a bit of a look at vpn_openvpn_server.php and recent changes, but I can't spot what the problem is.

[jimp]

Should be fixed by this:
https://github.com/bsdperimeter/pfsense/commit/f54712b6c8cc69721ccfd5b26a23e62bca722b72