[FIXED] Service Watchdog - cannot detect DHCPv6 relay status

[doktornotor]

Thanks for this new package. There's a small issue with dhcrelay6 service, it never gets detected as running, so the cron keeps restarting it.  :) Presumably since is_service_running() eventually boils down to the default is_process_running() which expects dhcrelay6 process and does exec pgrep -anx dhcrelay6 to check, while the process name is just dhcrelay.

Same issue might exist for other services special-cased in get_service_status() in service-utils.inc, such as vhosts-http or captiveportal.

[jimp]

If that is the case, it's probably also broken on the Status > Services page, is it not?

I don't have any systems with dhcrelay6 active to test against at the moment, I'll have to try it out.

(The package is very new, I planned on starting a forum thread for discussing it last night after I checked it in, but then ended up just going to sleep instead)

[doktornotor]

@jimp:

If that is the case, it's probably also broken on the Status > Services page, is it not?

Nope, it works there… (after some patches a couple weeks ago, before those it wasn't shown at all.)

https://github.com/pfsense/pfsense/commit/4701c8de28e7cb6c1f06cfbd4500631e574d012a
https://github.com/pfsense/pfsense/commit/9590e0de97bef964f16117f0094db24406754b64

However, AFAICT it uses the special-cased custom code there, i.e.,

$running = is_pid_running("{$g['varrun_path']}/dhcrelay6.pid");

instead of is_service_running()

[jimp]

ok, fix is coming in a few minutes after some more testing.

[jimp]

Also, as you have seen but in case others see this thread first, the new "official" thread for the package is here:
http://forum.pfsense.org/index.php/topic,65933.0.html

[doktornotor]

All good now, thanks!

(Will post other issues to the new thread  if required.)