• Categories
  • Recent
  • Tags
  • Popular
  • Users
  • Search
  • Register
  • Login
Netgate Discussion Forum
  • Categories
  • Recent
  • Tags
  • Popular
  • Users
  • Search
  • Register
  • Login

DynamicDNS should allow "@" at hostname

Scheduled Pinned Locked Moved DHCP and DNS
4 Posts 3 Posters 1.2k Views
Loading More Posts
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • F
    fdcastel
    last edited by Oct 21, 2014, 2:47 PM

    I opened the following issue into pfSense

    https://redmine.pfsense.org/issues/3900

    But ain't got any replies. Could somebody help?

    No-ip has the ability to update one of several IP addresses of a round-robin DNS A record. This is done adding a "@<label>" suffix at hostname. Eg.

    myhost@mydomain.no-ip.com@label1
      myhost@mydomain.no-ip.com@label2

    However, trying to add such hostname in services_dyndns_edit.php results in the following error:

    The following input errors were detected:

    The Hostname contains invalid characters.

    Confirmed on pfSense 2.1.5

    BTW, where these configs are stored? Could I change them directly via Diagnostics / Edit File? It would be a good workaround, for now.</label>

    1 Reply Last reply Reply Quote 0
    • R
      rjcrowder
      last edited by Oct 21, 2014, 2:58 PM

      If you want to get around it in the short term, just go change the PHP code for the page. Sounds like a pretty easy fix… If you're really ambitious, figure out how to setup GIT and push a change back to the team!!!

      The joy of using an open source firewall  ;D

      1 Reply Last reply Reply Quote 0
      • F
        fdcastel
        last edited by Oct 21, 2014, 5:44 PM

        DOOOH! I can't believe I didn't think of that!  ::)

        I changed usr\local\www\services_dyndns_edit.php:109 from

        if (($_POST['host'] && !is_domain($_POST['host'])))

        to

        if (($_POST['host'] && !is_domain(str_replace('@', '', $_POST['host'])))) /* Fixes Bug #3900: allow "@" in hostnames (for No-Ip) */

        I'll send a Github pull request for it. Soooo hardcore… 8)

        1 Reply Last reply Reply Quote 0
        • P
          phil.davis
          last edited by Oct 23, 2014, 4:33 AM

          For a little change like that, online-editing in GitHub is easy. You can easily select the file in master and press the pencil to edit, save and pull request. Then repeat for 2.1.x by browsing RELENG_2_1 branch.

          As the Greek philosopher Isosceles used to say, "There are 3 sides to every triangle."
          If I helped you, then help someone else - buy someone a gift from the INF catalog http://secure.inf.org/gifts/usd/

          1 Reply Last reply Reply Quote 0
          4 out of 4
          • First post
            4/4
            Last post
          Copyright 2025 Rubicon Communications LLC (Netgate). All rights reserved.
            This community forum collects and processes your personal information.
            consent.not_received